Adds TracingSpan() and logging to CRPCTable::execute to log elapsed rpc execution time. #6833
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pc execution time.
LarryRuane
requested changes
Feb 15, 2024
Comment on lines
+471
to
+472
| auto span = TracingSpan("info", "rpc", "Execute", "method", strMethod.c_str()); | ||
| auto spanGuard = span.Enter(); |
There was a problem hiding this comment.
These two lines don't seem to be necessary. I think they're for when one thread can start a timer and possibly different thread ends the timing interval. But @str4d will know for sure.
Co-authored-by: Larry Ruane <larryruane@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request adds logging for the completion of RPC methods detailing the elapsed execution time from the start of the execution function to a successful execution.
Issue: #5551