Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc/book/src/user/installation.md and remove readthedocs.io references. #6779

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nathan-at-least
Copy link
Contributor

@nathan-at-least nathan-at-least commented Oct 26, 2023

Context: we used to host some docs on https://zcash.readthedocs.io/en/latest/rtd_pages/zcashd.html and that's gone so we're striving to consolidate docs into the zcashd book in this repo.

Edit 2024-04-25: that page on readthedocs was restored.

This adds an installation page to the book, which (currently) only contains Debian instructions.

Important details:

  • I got the instructions from zcash.readthedocs.io in the wayback machine, then dusted them off a bit, including updating the apt signing key fingerprint and removing zcash-fetch-params step. I also followed those instructions on a Debian Bullseye vm.
  • I updated doc/release-process.md to check that apt fingerprint in the pre-release process.
  • I tweaked the top-level README.md to replace readthedocs links with internal mdbook links. The issue here is that this works/makes sense in an mdbook rendering, but may be confusing in the top-level README.md context (such as github repo homepage). I added an html comment in order to help local file readers make the connection.

@nathan-at-least nathan-at-least added A-documentation Area: Documentation C-tech-debt Category: Technical debt that needs to be paid off Death By A Thousand Cuts labels Oct 26, 2023
@nathan-at-least
Copy link
Contributor Author

This should resolve #6778 .

@str4d str4d added this to the Release 5.8.0 milestone Nov 2, 2023
@@ -1 +1 @@
Please read [our Development Guidelines](https://zcash.readthedocs.io/en/latest/rtd_pages/development_guidelines.html).
Please read [our Development Guidelines](doc/book/src/dev.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is to the top-level page for the developer documentation, which doesn't have any of the necessary information and isn't rendered with links. We should either change this to point to the rendered version:

Suggested change
Please read [our Development Guidelines](doc/book/src/dev.md).
Please read [our Development Documentation](https://zcash.github.io/zcash/dev.html).

or recreate the developer documentation page. For now I suggest changing the link.


```
wget -qO - https://apt.z.cash/zcash.asc | gpg --import
gpg --export B1C9095EAA1848DBB54D9DDA1D05FDC66B372CFE | sudo apt-key add -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not verified this key handle.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I calculated this with these commands:

$ wget -qO - https://apt.z.cash/zcash.asc | gpg --import
gpg: key 1D05FDC66B372CFE: "Zcash Master Signing Key (Electric Coin Company) <sysadmin@z.cash>" not changed
gpg: Total number processed: 1
gpg:              unchanged: 1

$ gpg --fingerprint 1D05FDC66B372CFE
pub   rsa3072 2023-06-19 [SC]
      B1C9 095E AA18 48DB B54D  9DDA 1D05 FDC6 6B37 2CFE
uid           [ unknown] Zcash Master Signing Key (Electric Coin Company) <sysadmin@z.cash>
sub   rsa3072 2023-06-19 [E]

$ gpg --fingerprint 1D05FDC66B372CFE | grep 2CFE | sed 's/ *//g'
B1C9095EAA1848DBB54D9DDA1D05FDC66B372CFE

So this is relying on apt.z.cash (and the wget/tls/gpg toolchain). We should verify this matches the debian signing keypair we use for deploying those packages.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key used is the correct one, it is the one used for debian package releases.

See the Zcash documentation wiki (https://zcash.readthedocs.io/en/latest/rtd_pages/zcashd.html) for instructions on building zcashd,
the intended-for-services, no-graphical-interface, reference
implementation of Zcash.
See [the Zcashd book](doc/book/src/) for installation, build, and operation instructions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link to the rendered version in this case (as this file is aimed at users, not contributors):

Suggested change
See [the Zcashd book](doc/book/src/) for installation, build, and operation instructions.
See [the `zcashd` book](https://zcash.github.io/zcash/) for installation, build, and operation instructions.

Comment on lines -59 to -60
* :blue_book: See the documentation at the [ReadTheDocs](https://zcash.readthedocs.io)
for help and more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this removal and change it to See [the `zcashd` book](https://zcash.github.io/zcash/)

@nathan-at-least
Copy link
Contributor Author

nathan-at-least commented Nov 2, 2023

TODO:

for instructions on joining the main Zcash network.
Please see our [user documentation](user.md) for instructions on joining the main Zcash network.

<!-- Relative link destinations like `user.md` live under `./doc/book/src`. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be possible to make this link Just Work, at least on a Unix checkout:

  1. Move all book content into a subdirectory, say guide.
  2. Symlink guide to doc/book/src/guide.


## Different Instruction Sets

Only x86-64 processors are supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? We have Tier 3 support for aarch64-linux-gnu.


If you’re starting from a new virtual machine, sudo may not come installed. See this issue for instructions to get up and running: https://github.com/zcash/zcash/issues/1844

## libgomp1 or libstdc++6 version problems
Copy link
Contributor

@daira daira Nov 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libgomp1 was related to OpenMP which we no longer use. Also we don't dynamically link to libstdc++6 any more, we statically link libc++. This whole section should be removed. (Definitely trying to "upgrade" to gcc/g++ 4.9 will not help; that is very out-of-date advice.)


## Tor

The repository is also accessible via Tor, after installing the apt-transport-tor package, at the address zcaptnv5ljsxpnjt.onion. Use the following pattern in your sources.list file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check that this still works, and delete the section if not.

sudo apt-key del AEFD26F966E279CD
```

Then [retrieve the latest key](#fetching-a-new-signing-key), then rerun `sudo apt update`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then [retrieve the latest key](#fetching-a-new-signing-key), then rerun `sudo apt update`.
[Retrieve the latest key](#fetching-a-new-signing-key), then rerun `sudo apt update`.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request to remove the section on libgomp1 and libstdc++6 is blocking.

@str4d str4d modified the milestones: Release 5.8.0, Post 5.8.0 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation C-tech-debt Category: Technical debt that needs to be paid off Death By A Thousand Cuts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants