-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detailed trace-level logging to get_spend_info
#6738
Open
nuttycom
wants to merge
3
commits into
zcash:master
Choose a base branch
from
nuttycom:wallet/orchard_inconsistency_logging
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add detailed trace-level logging to get_spend_info
#6738
nuttycom
wants to merge
3
commits into
zcash:master
from
nuttycom:wallet/orchard_inconsistency_logging
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
reviewed
Sep 22, 2023
daira
reviewed
Sep 22, 2023
daira
reviewed
Sep 22, 2023
daira
reviewed
Sep 22, 2023
daira
reviewed
Sep 22, 2023
daira
previously approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK with a blocking comment.
…startup. Author: Kris Nuttycombe <kris@nutty.land> Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
wallet/orchard_inconsistency_logging
branch
from
September 22, 2023 19:34
6ad21fb
to
99b10cd
Compare
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
wallet/orchard_inconsistency_logging
branch
from
September 22, 2023 19:35
99b10cd
to
a714137
Compare
daira
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.