Add z_listutxos method #6737
Open
Add z_listutxos method #6737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
commented
Jun 25, 2023
|
|
||
| LOCK2(cs_main, pwalletMain->cs_wallet); | ||
|
|
||
| // Get the receivers for this account. |
There was a problem hiding this comment.
Whoops. Copy-pasta.
buck54321
commented
Jun 25, 2023
| "\nArguments:\n" | ||
| "1. account (numeric) The account number.\n" | ||
| "2. minconf (numeric, optional, default=1) Only include transactions confirmed at least this many times.\n" | ||
| "3. maxconf (numeric, optional, default=9999999) The maximum confirmations to filter\n" |
There was a problem hiding this comment.
I don't personally see a reason for this argument to exist, but whoever added it to listunspent probably knew more than I do.
|
This PR is just a suggestion, of course. Just wanted to offer a solution to my complaints. I'd love to chat (maybe off-github) on the best way to get the info I need. |
z_listutxos is the zip-0032-account-compatible version of listunspent. The name z_listunspent was already taken, z_listunspent only returns shielded notes, and the return structure is incompatible with transparent outputs. listunspent takes no account argument, returns no account data, and from what I can tell, there's no appetite for modifying the legacy APIs for zip-0032 accounts.
buck54321
force-pushed
the
z-utxos-methods
branch
from
a2bf038
to
b804ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z_listutxosis the zip-0032-account-compatible version oflistunspent. The namez_listunspentwas already taken,z_listunspentonly returns shielded notes, and the return structure is incompatible with transparent outputs.listunspenttakes no account argument, returns no account data, and from what I can tell, there's no appetite for modifying the legacy APIs for zip-0032 accounts.I don't know if the "z_" prefix is appropriate. Seems like that prefix is associated variably with 1) working with shielded pools, and 2) working with zip-0032 accounts.
Partial resolution of #6679.