Update release process #6669
Draft
Update release process #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various changes or clarifications to the process that were useful when getting v5.5.1 out.
daira
reviewed
May 17, 2023
|
|
||
| ## Pre-pre-release | ||
|
|
||
| These are steps that can be considered done even weeks ahead of the release, so if you know you are going to be running an upcoming release, you can get ahead of the game and start these steps. |
There was a problem hiding this comment.
The existing file is line-wrapped, so the additions should be too.
daira
reviewed
May 17, 2023
|
|
||
| If you had one in the past, it might have expired. If it did, it’s easy to regenerate it. | ||
|
|
||
| 1. visit [GitHub’s personal access tokens page](https://github.com/settings/tokens?type=beta). |
There was a problem hiding this comment.
Suggested change
| 1. visit [GitHub’s personal access tokens page](https://github.com/settings/tokens?type=beta). | |
| 1. Visit [GitHub’s personal access tokens page](https://github.com/settings/tokens?type=beta). |
and similarly for the other points and the headings.
daira
reviewed
May 17, 2023
| ``` | ||
| #### Update [`src/chainparams.cpp`](../src/chainparams.cpp) | ||
|
|
||
| Call `getblockchaininfo` against an up-to-date mainnet note and copy the value of the “chainwork” field to `consensus.nMinimumChainWork` in the definition of `CMainParams::CMainParams()` (be careful to not update `CTestNetParams` or `CRegTestParams`). |
There was a problem hiding this comment.
Suggested change
| Call `getblockchaininfo` against an up-to-date mainnet note and copy the value of the “chainwork” field to `consensus.nMinimumChainWork` in the definition of `CMainParams::CMainParams()` (be careful to not update `CTestNetParams` or `CRegTestParams`). | |
| Call `getblockchaininfo` against an up-to-date mainnet node and copy the value of the “chainwork” field to `consensus.nMinimumChainWork` in the definition of `CMainParams::CMainParams()`. Be careful to not update `CTestNetParams` or `CRegTestParams`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes or clarifications to the process that were useful when getting
v5.5.1 out.