Reduce re-enabled diagnostics #6636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sellout
added
A-build
sellout
force-pushed
the
reduce-reenabled-diagnostics
branch
from
8306d39
to
2d05e40
Compare
daira
reviewed
May 4, 2023
daira
reviewed
May 5, 2023
daira
reviewed
May 5, 2023
daira
previously approved these changes
May 5, 2023
|
I opened sellout#3 onto this branch. |
sellout
force-pushed
the
reduce-reenabled-diagnostics
branch
2 times, most recently
from
b2184e7
to
3a4884b
Compare
Closed
sellout
force-pushed
the
reduce-reenabled-diagnostics
branch
from
3a4884b
to
9b4032d
Compare
daira
reviewed
May 11, 2023
| @@ -2324,7 +2324,7 @@ void CNode::AskFor(const CInv& inv) | |||
|
|
|||
| void CNode::BeginMessage(const char* pszCommand) EXCLUSIVE_LOCK_FUNCTION(cs_vSend) | |||
| { | |||
| ENTER_CRITICAL_SECTION(cs_vSend); | |||
| ENTER_CRITICAL_SECTION(cs_vSend) | |||
There was a problem hiding this comment.
If there were more uses of {ENTER,LEAVE}_CRITICAL_SECTION then I'd suggest altering the macros to avoid the warning, but it turns out there are only 8 uses of either macro in the whole codebase.
There was a problem hiding this comment.
I edited the macros in other places where it made sense (e.g., 52f4105#diff-b1924661640b70276005001174b3b3640f02be7232bb8d9a1b9518dde32f8055R189). But here (and for ADD_SERIALIZE_METHODS in #6641) the structure of the macro made it non-obvious how I could make that change.
daira
reviewed
May 11, 2023
daira
reviewed
May 11, 2023
daira
reviewed
May 11, 2023
daira
reviewed
May 11, 2023
daira
reviewed
May 11, 2023
daira
reviewed
May 11, 2023
daira
reviewed
May 11, 2023
daira
reviewed
May 11, 2023
daira
reviewed
May 11, 2023
daira
requested changes
May 11, 2023
There was a problem hiding this comment.
Backporting the removal of PostCommand/OnPostCommand in bitcoin/bitcoin#9575 instead of fixing it is blocking.
sellout
force-pushed
the
reduce-reenabled-diagnostics
branch
3 times, most recently
from
b0dfbbd
to
0e879ef
Compare
Some of the sub-warnings are still disabled.
Our only change is to rename a var from `requires` (which is a C++20 keyword) to `dependencies`.
Most re-enabled diagnostics have been removed. The remaining ones are tied to diagnostics that require deeper changes. This makes the parent diagnostics explicit so it’s easier to identified when the remaining re-enabled flags should be removed from the list.
sellout
force-pushed
the
reduce-reenabled-diagnostics
branch
from
0e879ef
to
1234ebe
Compare
|
I will take over this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many Clang diagnostic flags both have their own warnings as well as control
other subflags. This PR addresses the warnings that are reported directly by
these mixed flags, reducing the number of sub-flag diagnostics we need to
re-enable.
Since they control other subflags, enabling the superflag often means disabling
other subflags that also trigger warnings.