Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed25519-zebra 3 #5398

Merged
merged 4 commits into from Dec 17, 2021
Merged

ed25519-zebra 3 #5398

merged 4 commits into from Dec 17, 2021

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Nov 29, 2021

This is the versioned release of the git revision we were previously pinning.

Also bumps the other Rust dependencies.

@str4d str4d added A-dependencies Area: Dependencies L-rust Involves Rust code. labels Nov 29, 2021
@str4d str4d added this to the Core Sprint 2021-46 milestone Nov 29, 2021
@str4d
Copy link
Contributor Author

str4d commented Nov 29, 2021

Low-priority; we should hold off merging this until after #5391 merges.

@str4d
Copy link
Contributor Author

str4d commented Nov 29, 2021 •
edited

The (trivial) changes since the pinned revision: ZcashFoundation/ed25519-zebra@d351240...3.0.0

nuttycom
nuttycom previously approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@r3ld3v r3ld3v added the S-committed Status: Planned work in a sprint label Dec 7, 2021
@str4d
cargo update
df0534e 
Thanks to metrics-rs/metrics#231 being merged, our dependency tree is
now almost entirely de-duplicated!
nuttycom
nuttycom previously approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@nuttycom
Copy link
Contributor

I note that this differs slightly from what I get from running a cargo update today: tokio is now available at version 1.15.0, and proc-macro2 and a couple other dependencies have slightly newer versions available.

@str4d
Copy link
Contributor Author

str4d commented Dec 16, 2021

It's only been three days 😭

I'll have a look locally and see if any of them are useful. I can easily update this PR again, at the cost of another CI loop.

@str4d
Copy link
Contributor Author

str4d commented Dec 16, 2021

Upgrading locally, I see the following changes:

    Updating futures-channel v0.3.18 -> v0.3.17
    Updating futures-core v0.3.18 -> v0.3.17
    Updating futures-task v0.3.18 -> v0.3.17
    Updating futures-util v0.3.18 -> v0.3.17
    Updating once_cell v1.8.0 -> v1.9.0
    Updating proc-macro2 v1.0.33 -> v1.0.34
    Updating tokio v1.14.0 -> v1.15.0
    Updating tokio-macros v1.6.0 -> v1.7.0

Notice the downgrade. futures-core 0.3.18 was yanked yesterday: rust-lang/futures-rs#2529 (comment)

So we definitely want the changes!

@str4d
cargo update
e257844 
In the three days since the last update, `futures 0.3.18` was yanked due
to panics: rust-lang/futures-rs#2529
@nuttycom
Copy link
Contributor

Ah, I had noticed the downgrade in the diff and it confused me; I should have mentioned it, good catch!

@str4d str4d added safe-to-build Used to send PR to prod CI environment and removed safe-to-build Used to send PR to prod CI environment labels Dec 16, 2021
@mdr0id mdr0id added safe-to-build Used to send PR to prod CI environment and removed safe-to-build Used to send PR to prod CI environment labels Dec 16, 2021
@str4d str4d merged commit 9e4b6f6 into zcash:master Dec 17, 2021
@str4d str4d deleted the ed25519-zebra-3 branch December 17, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebfull ebfull ebfull approved these changes

@nuttycom nuttycom nuttycom left review comments

Assignees
No one assigned
Labels
A-dependencies Area: Dependencies L-rust Involves Rust code. S-committed Status: Planned work in a sprint safe-to-build Used to send PR to prod CI environment
Projects
None yet
Milestone
Core Sprint 2021-48
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@str4d @nuttycom @ebfull @mdr0id @r3ld3v