Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zcash_primitives: Replace
sapling::redjubjub
withredjubjub
crate #1056zcash_primitives: Replace
sapling::redjubjub
withredjubjub
crate #1056Changes from 1 commit
de1ed21
5ccba3e
ded09f9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a bug here previously in that this didn't include key prefixing, because we never implemented that inside our
redjubjub
module (as the original RedDSA draft spec lacked it). I should have used the equivalent of thesapling::spend_sig
method here when I added this in #1023 (not that exact method because it also handled re-randomization), but as we haven't cut a release including this API yet, the bug is not in deployed code. Theredjubjub
crate includes key prefixing.Check warning on line 804 in zcash_primitives/src/sapling/builder.rs
Codecov / codecov/patch
zcash_primitives/src/sapling/builder.rs#L804
Check warning on line 811 in zcash_primitives/src/sapling/builder.rs
Codecov / codecov/patch
zcash_primitives/src/sapling/builder.rs#L811
Check warning on line 820 in zcash_primitives/src/sapling/builder.rs
Codecov / codecov/patch
zcash_primitives/src/sapling/builder.rs#L819-L820
Check warning on line 927 in zcash_primitives/src/sapling/builder.rs
Codecov / codecov/patch
zcash_primitives/src/sapling/builder.rs#L926-L927