[draft] Implement Rbac Engine #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
force-pushed
the
rbac-engine-rebased
branch
from
7457f83
to
b3fa6ef
Compare
dfawley
reviewed
May 13, 2021
| // based on the Envoy RBAC Proto, and will be created in two use cases, one in regular | ||
| // gRPC and one from XDS and TrafficDirector. The engine will then be passed in data pulled | ||
| // from incoming RPC's to the server side. | ||
| type RbacEngine struct { |
There was a problem hiding this comment.
RBACEngine
(if not exported:)
rbacEngine
| // based on a policy. This policy will be used to instantiate a tree | ||
| // of matchers that will be used to make an authorization decision on | ||
| // an incoming RPC. | ||
| func NewRbacEngine(policy *v3rbacpb.RBAC) *RbacEngine { |
| // evaluateArgs represents the data pulled from an incoming RPC to a gRPC server. | ||
| // This data will be passed around the RBAC Engine and pass through the logical tree of matchers, | ||
| // and will help determine whether a RPC is allowed to proceed. | ||
| type evaluateArgs struct { |
There was a problem hiding this comment.
Exported all api level data and fields.
Comment on lines
45
to
46
| // This data will be passed around the RBAC Engine and pass through the logical tree of matchers, | ||
| // and will help determine whether a RPC is allowed to proceed. |
There was a problem hiding this comment.
Deleted impl details from top level API comments.
Comment on lines
11
to
16
| // authorizationDecision is what will be returned from the RBAC Engine | ||
| // when it is asked to see if an rpc should be allowed or denied. | ||
| type authorizationDecision struct { | ||
| decision v3rbacpb.RBAC_Action | ||
| matchingPolicyName string | ||
| } |
| @@ -0,0 +1,71 @@ | |||
| package authorization | |||
internal/authorization/matchers.go
Outdated
| principals *orMatcher | ||
| } | ||
|
|
||
| func createPolicyMatcher(policy *v3rbacpb.Policy) *policyMatcher { |
There was a problem hiding this comment.
Switched all createX to newX. Left createListFromPermission/Policy as that is not a tree node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For comments and guidance