-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds checksum flag to zstd codec #519
base: main
Are you sure you want to change the base?
Conversation
I would love a review on this so that we can ship this in the upcoming zarr-python 3 release. |
@mkitti would you mind giving this a look? |
A good time to switch to cramjam? Does this zstd provide anything that that one doesn't? |
|
I'm looking. We should normalize the implementation here such that negative compression levels are passed on to the C library and that the default compression level is the default compression level of the underlying C library. |
The default CLEVEL here should be changed to
|
I made that change. This is a breaking change, though. |
This PR adds the
checksum
flag to thezstd
codec. This is necessary to support the proposedzstd
codec for Zarr3. We need it for the v3 refactoring of zarr-python.TODO: