Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change occurrences of format() to f-strings #439

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DimitriPapadopoulos
Copy link
Contributor

Also change one occurrence of % to format(), as changing to an f-string would result in a very long line.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #439 (d781c17) into main (515d097) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d781c17 differs from pull request most recent head 7261c1e. Consider uploading reports for the commit 7261c1e to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #439   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         2242      2241    -1     
=========================================
- Hits          2242      2241    -1     
Files Coverage Δ
numcodecs/abc.py 100.00% <100.00%> (ø)
numcodecs/compat.py 100.00% <100.00%> (ø)
numcodecs/delta.py 100.00% <100.00%> (ø)
numcodecs/json.py 100.00% <100.00%> (ø)
numcodecs/tests/common.py 100.00% <100.00%> (ø)
numcodecs/zfpy.py 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant