Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify language as 'en' instead of None #329

Merged
merged 1 commit into from Jun 22, 2022
Merged

Specify language as 'en' instead of None #329

merged 1 commit into from Jun 22, 2022

Conversation

jakirkham
Copy link
Member

Needed for Sphinx 5 compatibility. Should fix warning on CI.

Warning, treated as error:
[88](https://github.com/zarr-developers/numcodecs/runs/6993269158?check_suite_focus=true#step:8:89)
Invalid configuration value found: 'language = None'. Update your configuration to a valid langauge code. Falling back to 'en' (English).

xref: sphinx-doc/sphinx#10481


  • Unit tests and/or doctests in docstrings
  • tox -e py39 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Coveralls passes)

Needed for Sphinx 5 compatibility. Should fix warning on CI.
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the current URLs already have en regardless (https://numcodecs.readthedocs.io/en/stable/ vs. https://numcodecs--329.org.readthedocs.build/en/329/) I'd say, 👍

@joshmoore joshmoore merged commit 4ca5246 into zarr-developers:main Jun 22, 2022
@jakirkham jakirkham deleted the doc_cfg_lang_en branch June 23, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants