WIP: pure python #274
Draft
WIP: pure python #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* snappy: not compiled into wheel by default * decompress_partial: needs implementing * AUTOSHUFFLE: needs implementing
Unfortunately, this wasn't immediately put under revision control and has undergone a number of changes. Original versions were largely lifted out of blosc.pyx.
|
Hello @joshmoore! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-02-18 15:13:38 UTC |
joshmoore
force-pushed
the
pure-py
branch
2 times, most recently
from
fd05e21
to
48b277b
Compare
2 tasks
This was referenced Jul 28, 2021
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #259 (comment), I dropped the blosc module and am slowly making changes in the background to use native blosc wheels, turning this into a pure Python module. If anyone would like to add commits, please feel free (especially if you know what you are doing unlike myself...)
TODO:
tox -e py39passes locallytox -e docspasses locally