refactor: refactor deprecated new Buffer to Buffer.from (typeorm#5924)

src/driver/sqljs/SqljsDriver.ts

@@ -75,7 +75,7 @@ export class SqljsDriver extends AbstractSqliteDriver {
 
         return this.queryRunner;
     }
-    
+
     /**
      * Loads a database from a given file (Node.js), local storage key (browser) or array.
      * This will delete the current database!
@@ -99,7 +99,7 @@ export class SqljsDriver extends AbstractSqliteDriver {
                     // File will be written on first write operation.
                     return this.createDatabaseConnectionWithImport();
                 }
-            } 
+            }
             else {
                 // browser
                 // fileNameOrLocalStorageOrData should be a local storage / indexedDB key
@@ -113,7 +113,7 @@ export class SqljsDriver extends AbstractSqliteDriver {
                 } else {
                     localStorageContent = PlatformTools.getGlobalVariable().localStorage.getItem(fileNameOrLocalStorageOrData);
                 }
-                
+
                 if (localStorageContent != null) {
                     // localStorage value exists.
                     return this.createDatabaseConnectionWithImport(JSON.parse(localStorageContent));
@@ -143,7 +143,7 @@ export class SqljsDriver extends AbstractSqliteDriver {
         if (!location && !this.options.location) {
             throw new Error(`No location is set, specify a location parameter or add the location option to your configuration`);
         }
-        
+
         let path = "";
         if (location) {
             path = location;
@@ -154,7 +154,7 @@ export class SqljsDriver extends AbstractSqliteDriver {
 
         if (PlatformTools.type === "node") {
             try {
-                const content = new Buffer(this.databaseConnection.export());
+                const content = Buffer.from(this.databaseConnection.export());
                 await PlatformTools.writeFile(path, content);
             }
             catch (e) {
@@ -193,7 +193,7 @@ export class SqljsDriver extends AbstractSqliteDriver {
             }
         }
     }
-    
+
     /**
      * Returns the current database as Uint8Array.
      */
@@ -284,4 +284,4 @@ export class SqljsDriver extends AbstractSqliteDriver {
             }
         }
     }
-}
+}

test/functional/database-schema/column-types/mssql/column-types-mssql.ts

@@ -48,9 +48,9 @@ describe("database schema > column types > mssql", () => { // https://github.com
         post.nchar = "A";
         post.nvarchar = "This is nvarchar";
         post.ntext = "This is ntext";
-        post.binary = new Buffer("A");
-        post.varbinary = new Buffer("B");
-        post.image = new Buffer("This is image");
+        post.binary = Buffer.from("A");
+        post.varbinary = Buffer.from("B");
+        post.image = Buffer.from("This is image");
         post.dateObj = new Date();
         post.date = "2017-06-21";
         post.datetime = new Date();
@@ -182,8 +182,8 @@ describe("database schema > column types > mssql", () => { // https://github.com
         post.varchar = "This is varchar";
         post.nchar = "AAA";
         post.nvarchar = "This is nvarchar";
-        post.binary = new Buffer("AAAAA");
-        post.varbinary = new Buffer("BBBBB");
+        post.binary = Buffer.from("AAAAA");
+        post.varbinary = Buffer.from("BBBBB");
         post.datetime2 = new Date();
         post.time = new Date();
         post.datetimeoffset = new Date();
@@ -252,7 +252,7 @@ describe("database schema > column types > mssql", () => { // https://github.com
         post.id = 1;
         post.name = "Post";
         post.bit = true;
-        post.binary = new Buffer("A");
+        post.binary = Buffer.from("A");
         post.datetime = new Date();
         post.datetime.setMilliseconds(0); // set milliseconds to zero because the SQL Server datetime type only has a 1/300 ms (~3.33̅ ms) resolution
         await postRepository.save(post);

test/functional/database-schema/column-types/mysql/column-types-mysql.ts

@@ -61,12 +61,12 @@ describe("database schema > column types > mysql", () => {
         post.timestamp.setMilliseconds(0); // set milliseconds to zero, because if datetime type specified without precision, milliseconds won't save in database
         post.time = "15:30:00";
         post.year = 2017;
-        post.binary = new Buffer("A");
-        post.varbinary = new Buffer("B");
-        post.blob = new Buffer("This is blob");
-        post.tinyblob = new Buffer("This is tinyblob");
-        post.mediumblob = new Buffer("This is mediumblob");
-        post.longblob = new Buffer("This is longblob");
+        post.binary = Buffer.from("A");
+        post.varbinary = Buffer.from("B");
+        post.blob = Buffer.from("This is blob");
+        post.tinyblob = Buffer.from("This is tinyblob");
+        post.mediumblob = Buffer.from("This is mediumblob");
+        post.longblob = Buffer.from("This is longblob");
         post.geometry = "POINT(1 1)";
         post.point = "POINT(1 1)";
         post.linestring = "LINESTRING(0 0,1 1,2 2)";
@@ -278,7 +278,7 @@ describe("database schema > column types > mysql", () => {
         post.id = 1;
         post.name = "Post";
         post.boolean = true;
-        post.blob = new Buffer("A");
+        post.blob = Buffer.from("A");
         post.datetime = new Date();
         post.datetime.setMilliseconds(0); // set milliseconds to zero, because if datetime type specified without precision, milliseconds won't save in database
         await postRepository.save(post);

test/functional/database-schema/column-types/oracle/column-types-oracle.ts

@@ -43,7 +43,7 @@ describe("database schema > column types > oracle", () => {
         post.varchar2 = "This is varchar2";
         post.nvarchar2 = "This is nvarchar2";
         post.long = "This is long";
-        post.raw = new Buffer("This is raw");
+        post.raw = Buffer.from("This is raw");
         post.dateObj = new Date();
         post.date = "2017-06-21";
         post.timestamp = new Date();
@@ -52,7 +52,7 @@ describe("database schema > column types > oracle", () => {
         post.timestampWithTimeZone.setMilliseconds(0);
         post.timestampWithLocalTimeZone = new Date();
         post.timestampWithLocalTimeZone.setMilliseconds(0);
-        post.blob = new Buffer("This is blob");
+        post.blob = Buffer.from("This is blob");
         post.clob = "This is clob";
         post.nclob = "This is nclob";
         post.simpleArray = ["A", "B", "C"];
@@ -137,7 +137,7 @@ describe("database schema > column types > oracle", () => {
         post.nchar = "AAA";
         post.varchar2 = "This is varchar";
         post.nvarchar2 = "This is nvarchar";
-        post.raw = new Buffer("This is raw");
+        post.raw = Buffer.from("This is raw");
         post.timestamp = new Date();
         post.timestampWithTimeZone = new Date();
         post.timestampWithLocalTimeZone = new Date();
@@ -204,7 +204,7 @@ describe("database schema > column types > oracle", () => {
         post.id = 1;
         post.name = "Post";
         post.boolean = true;
-        post.blob = new Buffer("This is blob");
+        post.blob = Buffer.from("This is blob");
         post.datetime = new Date();
         await postRepository.save(post);
 

test/functional/database-schema/column-types/postgres/column-types-postgres.ts

@@ -48,7 +48,7 @@ describe("database schema > column types > postgres", () => {
         post.text = "This is text";
         post.citext = "This is text";
         post.hstore = "name => Alice, surname => A, age => 30";
-        post.bytea = new Buffer("This is bytea");
+        post.bytea = Buffer.from("This is bytea");
         post.date = "2017-06-21";
         post.interval = "1 year 2 months 3 days 4 hours 5 minutes 6 seconds";
         post.time = "15:30:00";

test/functional/database-schema/column-types/sap/column-types-sap.ts

@@ -54,12 +54,12 @@ describe("database schema > column types > sap", () => {
         post.timestamp.setMilliseconds(0);
         post.seconddate = new Date();
         post.seconddate.setMilliseconds(0);
-        post.blob = new Buffer("This is blob");
+        post.blob = Buffer.from("This is blob");
         post.clob = "This is clob";
         post.nclob = "This is nclob";
         post.boolean = true;
         // post.array = ["A", "B", "C"]; // TODO
-        post.varbinary = new Buffer("This is varbinary");
+        post.varbinary = Buffer.from("This is varbinary");
         post.simpleArray = ["A", "B", "C"];
         await postRepository.save(post);
 
@@ -187,7 +187,7 @@ describe("database schema > column types > sap", () => {
         post.id = 1;
         post.name = "Post";
         post.boolean = true;
-        post.blob = new Buffer("This is blob");
+        post.blob = Buffer.from("This is blob");
         post.timestamp = new Date();
         await postRepository.save(post);
 

test/functional/database-schema/column-types/sqlite/column-types-sqlite.ts

@@ -42,7 +42,7 @@ describe("database schema > column types > sqlite", () => {
         post.nchar = "This is nchar";
         post.nativeCharacter = "This is native character";
         post.nvarchar = "This is nvarchar";
-        post.blob = new Buffer("This is blob");
+        post.blob = Buffer.from("This is blob");
         post.clob = "This is clob";
         post.text = "This is text";
         post.real = 10.5;
@@ -150,7 +150,7 @@ describe("database schema > column types > sqlite", () => {
         post.id = 1;
         post.name = "Post";
         post.boolean = true;
-        post.blob = new Buffer("A");
+        post.blob = Buffer.from("A");
         post.datetime = new Date();
         post.datetime.setMilliseconds(0);
         await postRepository.save(post);