feat(core): add runtime check for performBulk #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliangcs
commented
May 14, 2024
| .filter((id) => id); | ||
|
|
||
| const outputIds = Object.keys(results); | ||
| const missingIds = inputIds.filter((id) => !outputIds.includes(id)); |
There was a problem hiding this comment.
@FokkeZB do you think if the output should contain all the IDs in the input (bundle.bulk)? The current implementation assumes yes.
There was a problem hiding this comment.
Yes, correct. With outputData and (or?) an optional error.
There was a problem hiding this comment.
Updated the requirements in the description. So now each item must have an outputData object or an error string.
kola-er
approved these changes
May 14, 2024
kola-er
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a runtime check
perform-bulk-return-typeto ensure the result returned by theperformBulkfunction follow the requirements:bundle.bulk.outputDataobject or anerrorstring.I found there was no integration test that ran all the checks in the checkOutput middleware, so I added one. Since I enabled the checks by adding
command: 'execute'here, some other test cases increate-app.jsstarted failing. I ended up refactoring many of the test cases.