Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDE-4989] feat(schema): Add support for bulk writes #782

Merged
merged 1 commit into from
May 10, 2024
Merged

[PDE-4989] feat(schema): Add support for bulk writes #782

merged 1 commit into from
May 10, 2024

Conversation

kola-er
Copy link
Contributor

@kola-er kola-er commented May 8, 2024

No description provided.

@kola-er kola-er force-pushed the PDE-4989 branch 2 times, most recently from b34f341 to ade59f6 Compare May 8, 2024 19:18
@kola-er kola-er requested a review from eliangcs May 8, 2024 21:10
@eliangcs
Copy link
Member

eliangcs commented May 9, 2024

cc @FokkeZB if you'd like to review too.

FokkeZB
FokkeZB approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@FokkeZB FokkeZB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but otherwise LGTM

packages/schema/docs/build/schema.md Outdated Show resolved Hide resolved
packages/schema/lib/schemas/BulkObjectSchema.js Show resolved Hide resolved
eliangcs
eliangcs previously approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@eliangcs eliangcs left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and it works great! I only have one small suggestion on the validation message. Otherwise, I think this is good to merge.

Should we merge this to a temporary branch like release-15.8.0 until all the bulk action changes are ready?

packages/schema/lib/functional-constraints/bulkWriteConstraints.js Outdated Show resolved Hide resolved
@kola-er kola-er changed the base branch from main to release-15.8.0 May 10, 2024 16:34
@kola-er kola-er merged commit 6b3570e into release-15.8.0 May 10, 2024
13 checks passed
@kola-er kola-er deleted the PDE-4989 branch May 10, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FokkeZB FokkeZB FokkeZB approved these changes

@eliangcs eliangcs eliangcs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kola-er @eliangcs @FokkeZB