Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Fix the tests for the new pytest-mock package structure #199

Merged
merged 1 commit into from
Oct 5, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Oct 5, 2019

Adjust to the changed pytest-mock internal structure.

Issue : #13

Description

In pytest-dev/pytest-mock#160, on 2019-10-04 23:56 CEST, pytest-mock=1.11.1 has changed its internal package-module structure.

Kopf used its structure to replace one internal method to properly replace all mocks with async/awaitable mocks for total async transparency of the tests. After the change, Kopf's hack stopped having any effect.

Yes, it is a bad practice, but this simplifies testing a lot, and there is no public interface for this.

This does not affect the Kopf itself, but only its tests (and therefore, all PRs that are (not) happening after this release).

This PR adjusts for the new structure of pytest-mock.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label Oct 5, 2019
@nolar nolar requested a review from samurang87 as a code owner October 5, 2019 09:16
@zincr
Copy link

zincr bot commented Oct 5, 2019

🤖 zincr found 0 problems , 1 warning

ℹ️ Dependency Licensing
✅ Large Commits
✅ Approvals
✅ Specification

Details on how to resolve are provided below


Dependency Licensing

All dependencies specified in package manager files must be reviewed, banned dependency licenses will block the merge, all new dependencies introduced in this pull request will give a warning, but not block the merge

Please ensure that only dependencies with licenses compatible with the license of this project is included in the pull request.

  • ℹ️ Could not process requirements.txt for new dependencies
     

@zincr
Copy link

zincr bot commented Oct 5, 2019

🤖 zincr found 1 problem , 1 warning

❌ Approvals
ℹ️ Dependency Licensing
✅ Large Commits
✅ Specification

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

Dependency Licensing

All dependencies specified in package manager files must be reviewed, banned dependency licenses will block the merge, all new dependencies introduced in this pull request will give a warning, but not block the merge

Please ensure that only dependencies with licenses compatible with the license of this project is included in the pull request.

  • ℹ️ Could not process requirements.txt for new dependencies
     

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants