Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for x386 debian 11/12, amd64 debian 11/12, arm64 debian9/10/11/12 with test #145

Merged
merged 6 commits into from
May 9, 2024
Merged

Add support for x386 debian 11/12, amd64 debian 11/12, arm64 debian9/10/11/12 with test #145

merged 6 commits into from
May 9, 2024

Conversation

willnet
Copy link
Contributor

@willnet willnet commented Aug 8, 2022 •
edited

  • Added binaries for x386 debian 11/12, amd64 debian 11/12, arm64 debian9/10/11/12 and made them available for testing on GitHub Actions
    • Since we can't select arm64 platform in GitHub Actions on github.com, use docker/setup-qemu-action to virtually realize testing on arm64.
    • It was difficult to use the same docker-compose.yml and Dockerfile for x86 and arm64, so create docker-compose.yml and Dockerfile for arm64 version.
  • Since we are using docker to test on x86 ubuntu, we don't need multiple versions of Ruby on ubuntu, so we only use one version of Ruby.
  • Fixed a bug that the order of arguments of assert_equal method was reversed.
  • Loosened conditions for passing the test
    • Only 0.12.6.1 binaries are available under newer distributions such as debian11, so make the tests pass.
  • Add Ruby 3.2 to CI matrix
  • Fix a broken archlinux test
    • Fix an error that the libssl library could not be found
  • update github actions

@viseztrance viseztrance mentioned this pull request Sep 8, 2022
Closed
@LeEnno
Copy link

LeEnno commented Nov 8, 2022

This would close #121, #122 and #146.

I added the line…

gem 'wkhtmltopdf-binary', git: 'https://github.com/willnet/wkhtmltopdf_binary_gem.git', branch: 'arm'

…to my Gemfile and it works as expected with Docker (ruby:2.6.6-buster) on my Apple Silicon Mac. No more hacks necessary.

If you have a minute – @pedrofurtado and @unixmonkey – I would greatly appreciate your attention on this PR.

@willnet willnet changed the title Add support for arm64 debian9/10 with test Add support for x386 debian 11, amd64 debian 11, arm64 debian9/10/11 with test Feb 10, 2023
@willnet
Copy link
Contributor Author

willnet commented Feb 10, 2023

Add binaries for debian11.

@willnet
Copy link
Contributor Author

willnet commented Feb 10, 2023 •
edited

a test failure about archlinux is resolved by #156

@jeffbax
Copy link

jeffbax commented May 24, 2023

Would love to see this one get merged into the main repo!

@adamzapasnik adamzapasnik mentioned this pull request Jun 15, 2023
Closed
@slayer
Copy link

slayer commented Jul 11, 2023

Hey guys,

any news here?

@mikekosulin
Copy link
Contributor

up

@willnet willnet mentioned this pull request Nov 21, 2023
Closed
@willnet willnet changed the title Add support for x386 debian 11, amd64 debian 11, arm64 debian9/10/11 with test Add support for x386 debian 11/12, amd64 debian 11/12, arm64 debian9/10/11/12 with test Nov 21, 2023
@willnet
Add support for x386 debian 11/12, amd64 debian 11/12, arm64 debian9/…
c64d327 
…10/11/12 with test

- Added binaries for x386 debian 11/12, amd64 debian 11/12, arm64 debian9/10/11 and made them available for testing on GitHub Actions
  - Since we can't select arm64 platform in GitHub Actions on github.com, use [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) to virtually realize testing on arm64.
  - It was difficult to use the same docker-compose.yml and Dockerfile for x86 and arm64, so create docker-compose.yml and Dockerfile for arm64 version.
- Since we are using docker to test on x86 ubuntu, we don't need multiple versions of Ruby on ubuntu, so we only use one version of Ruby.
- Fixed a bug that the order of arguments of `assert_equal` method was reversed.
- Loosened conditions for passing the test
  - Only 0.12.6.1 binaries are available under newer distributions such as debian11, so make the tests pass.
- Add Ruby 3.2 to CI matrix
- Fix a broken archlinux test
  - Fix an error that the libssl library could not be found
- update github actions
@willnet
Copy link
Contributor Author

willnet commented Nov 21, 2023

I have added debian12 binaries.

Now debian9 fails to build, does anyone know a good solution for this?

@mikekosulin
Copy link
Contributor

I have added debian12 binaries.

Now debian9 fails to build, does anyone know a good solution for this?

Issue is due to End of Life (EOL).
Please check out my PR

@matthiaz
Copy link

matthiaz commented Dec 8, 2023

I made a new repo and merged the MR from @willnet https://github.com/matthiaz/wkhtmltopdf_binary_gem

I then pushed a new gem: https://rubygems.org/gems/wkhtmltopdf-binary-ng/versions/0.12.6.6 so it can be used by others

So in stead of using gem install wkhtmltopdf-binary you could use gem install wkhtmltopdf-binary-ng and roll with that.

Apart from this MR, nothing else was changed in the gem. But we could, if this repo stays stale...

@bernica
Copy link

bernica commented Dec 21, 2023

@zakird @pedrofurtado @unixmonkey is any of you maintaining this repo? Any thoughts or decision on this?

@gregorbg gregorbg mentioned this pull request Feb 8, 2024
Merged
unixmonkey
unixmonkey reviewed May 7, 2024
View reviewed changes
bin/wkhtmltopdf_debian_12_arm64 Outdated
Copy link
Collaborator

@unixmonkey unixmonkey May 7, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing this uncompressed (and duplicate) binary from this PR? I'm ready to accept otherwise 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. I've fixed it.

@willnet
Remove an unnecessary file that was added by mistake
5abae2d
@willnet
Fix CI failures by explicitly using Intel Mac
db918ca 
The image used by GitHub Actions for macos-latest has started using the M1 chip, causing CI failures. By explicitly specifying macos-13, we can prevent CI from failing.

ref: [GitHub Actions: macOS 14 (Sonoma) is now available - The GitHub Blog](https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/)
@unixmonkey unixmonkey merged commit aa4f409 into zakird:master May 9, 2024
10 checks passed
@unixmonkey
Copy link
Collaborator

Thank you! These contributions are now in version 0.12.6.7. Please check it and make sure it still works for you. I really appreciate you taking the time to fix the CI issues, and bringing over a bunch of the arm64 binaries.

@unixmonkey unixmonkey mentioned this pull request May 10, 2024
Closed
@willnet willnet deleted the arm branch May 10, 2024 02:04
@unixmonkey unixmonkey mentioned this pull request May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unixmonkey unixmonkey unixmonkey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@willnet @LeEnno @jeffbax @slayer @mikekosulin @matthiaz @bernica @unixmonkey