Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the correct location for vehicle_config. (#462) #463

Merged
merged 1 commit into from Mar 27, 2024

Conversation

kbrint
Copy link
Contributor

@kbrint kbrint commented Mar 27, 2024

No description provided.

@kbrint kbrint changed the title Use the correct location for vehicle_config. (#462) fix: Use the correct location for vehicle_config. (#462) Mar 27, 2024
@kbrint
Copy link
Contributor Author

kbrint commented Mar 27, 2024

I tried patching in the test only (to the previous dev branch) and they still all pass.

I think that is a separate bug, and that's possibly how this error slipped into the code in the first place.

@alandtse
Copy link
Collaborator

Thanks. I mean it's weird cause it reverts the prior change but we can see if it results in a revert war.

@alandtse alandtse merged commit 879b04e into zabuldon:dev Mar 27, 2024
4 of 5 checks passed
alandtse added a commit that referenced this pull request Mar 27, 2024
fix: Use the correct location for `vehicle_config`.  (#462) (#463)
@kbrint
Copy link
Contributor Author

kbrint commented Mar 27, 2024

Thanks. I mean it's weird cause it reverts the prior change but we can see if it results in a revert war.

The change in question (92774e9) modifies references to:

  • vehicle_config (the subject of this PR), and
  • vehicle_state, and
  • climate_state.

It appears that the vehicle_config contains immutable attributes of the vehicle (as opposed to the *_state entries). I don't think it needs to be refreshed often, nor should the values change if the car is offline. Anyway, this is where the data actually is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants