feat: Add media controls #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alandtse
reviewed
May 2, 2023
teslajsonpy/car.py
Outdated
| def safeget(dct, *keys, default=None): | ||
| """Get a recursuive object from a dict.""" | ||
| for key in keys: | ||
| try: |
There was a problem hiding this comment.
I don't use get, otherwise we end up with .get(...).get(...).get(....) and it can get quite long and messy.
This little helper function cleans that up.
If you're happy with it, in a later pull request, i can update all the others to use the helper function.
alandtse
reviewed
May 2, 2023
|
Just to confirm, did you still want to do this? |
Megabytemb
force-pushed
the
add-media-controls
branch
from
65ca349
to
cdcd5d9
Compare
|
Btw, I'm not sure why this touches every file in the repo. This will really muddle history. Can you figure out why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds abstractions and the adjust volume endpoint