refactor(qavatar): use composition API #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch and not themaster
branchfix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
No noticeable differences between JS or TS build, just the build time increase.
I guess we'll see them diverge as we proceed into migrating stuff to TS.
The resulting JS build size will slightly increase as there will always be a new composable for every mixin (even if the mixin will share the logic from the composable), but most of them will be tree-shaked away I guess
Seems like the buiild time increase is all due to type-checking.
Disabling type-checking reverts to 40-50s the build time.
Of course, disabling type-checking is not what you want, right after adding TS to your project, but Vue too disable it for dev builds and only enable it for prod builds, so they must have the same problem
Their rollup config: https://github.com/vuejs/vue-next/blob/master/rollup.config.js
They are also using the microsoft api extractor to extract and generate their type defs automatically (we might not want to do that right away) https://github.com/vuejs/vue-next/blob/master/scripts/build.js#L102