Merge pull request #448 from movsb/fix-attribute-string

make RenderAttributes() accept both []byte and string
yuin · Apr 3, 2024 · c15e394 · c15e394
2 parents ce6424a + e405d57
commit c15e394
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/renderer/html/html.go b/renderer/html/html.go
@@ -786,7 +786,14 @@ func RenderAttributes(w util.BufWriter, node ast.Node, filter util.BytesFilter)
 		_, _ = w.Write(attr.Name)
 		_, _ = w.WriteString(`="`)
 		// TODO: convert numeric values to strings
-		_, _ = w.Write(util.EscapeHTML(attr.Value.([]byte)))
+		var value []byte
+		switch typed := attr.Value.(type) {
+		case []byte:
+			value = typed
+		case string:
+			value = util.StringToReadOnlyBytes(typed)
+		}
+		_, _ = w.Write(util.EscapeHTML(value))
 		_ = w.WriteByte('"')
 	}
 }