Skip to content

Commit

Permalink
[#22375] docdb: Enable CDC immediate transaction cleanup
Browse files Browse the repository at this point in the history
Summary:
Enable CDC immediate transaction cleanup introduced in
D31900 / 559b2b0.

This enables cdc_immediate_transaction_cleanup and
docdb_ht_filter_intents in release, and converts
cdc_write_post_apply_metadata into an autoflag.
Jira: DB-11275

Test Plan: Jenkins

Reviewers: sergei

Reviewed By: sergei

Subscribers: rthallam, ybase

Differential Revision: https://phorge.dev.yugabyte.com/D34678
  • Loading branch information
es1024 committed May 14, 2024
1 parent a1d3b16 commit a722e0c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
4 changes: 1 addition & 3 deletions src/yb/docdb/doc_ql_filefilter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@

#include "yb/rocksdb/db/compaction.h"

#include "yb/util/debug.h"

DEFINE_RUNTIME_bool(docdb_ht_filter_intents, yb::kIsDebug,
DEFINE_RUNTIME_bool(docdb_ht_filter_intents, true,
"Use hybrid time SST filter when scanning intents.");

namespace yb::docdb {
Expand Down
6 changes: 2 additions & 4 deletions src/yb/tablet/transaction_participant.cc
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
#include "yb/util/async_util.h"
#include "yb/util/callsite_profiling.h"
#include "yb/util/countdown_latch.h"
#include "yb/util/debug.h"
#include "yb/util/flags.h"
#include "yb/util/format.h"
#include "yb/util/logging.h"
Expand Down Expand Up @@ -104,12 +103,11 @@ DEFINE_NON_RUNTIME_int32(wait_queue_poll_interval_ms, 100,
"The interval duration between wait queue polls to fetch transaction statuses of "
"active blockers.");

// TODO: this should be turned into an autoflag.
DEFINE_RUNTIME_bool(cdc_write_post_apply_metadata, yb::kIsDebug,
DEFINE_RUNTIME_AUTO_bool(cdc_write_post_apply_metadata, kLocalPersisted, false, true,
"Write post-apply transaction metadata to intentsdb for transaction that have been applied but "
" have not yet been streamed by CDC.");

DEFINE_RUNTIME_bool(cdc_immediate_transaction_cleanup, yb::kIsDebug,
DEFINE_RUNTIME_bool(cdc_immediate_transaction_cleanup, true,
"Clean up transactions from memory after apply, even if its changes have not yet been "
"streamed by CDC.");

Expand Down

0 comments on commit a722e0c

Please sign in to comment.