Skip to content

Commit

Permalink
[#10894] YSQL SMARTDRIVER: Pointing yb-pgsql tests to the latest jdbc…
Browse files Browse the repository at this point in the history
…-yugabytedb driver

Summary:
The degradation was because the upstream pgjdbc ( on 42.3.0 ) had introduced this performance issue in rb3d5fba91a9ddbd6c7e6bfce774f0c0cc94593b9 … upstream repo: git@github.com:pgjdbc/pgjdbc.git

This issue was reverted later on Oct 7th this year in commit: c4c35d1

```
Commit comment:

Revert "try to read any notifies or errors that come in asynchronously" (pgjdbc#2276)

Revert "fix: try to read any notifies or errors that come in asynchronously (try to read any notifies or errors that come in asynchronously pgjdbc/pgjdbc#2143)"
This reverts commit b3d5fba.

fix spacing on GSS_ENC_MODE (fix spacing on GSS_ENC_MODE [SKIP-CI] pgjdbc/pgjdbc#2280)
```

But by that time we had already forked our repo. With this change there was some unnecessary read of the sockets happening and in the process some buffer allocation happening which was the cause of the slowness.

I have merged the latest version i.e. 42.3.2 in our fork.
The smart driver jar referenced in the yb-pgsql pom.xml is the latest fixed version now.

Test Plan:
yb-sample-apps
yb-pgsql unit tests
smart driver demo apps in: https://github.com/yugabyte/pgjdbc/tree/master/examples

Reviewers: nikhil, ashetkar, mihnea, ssong

Reviewed By: ssong

Subscribers: ssong, yql

Differential Revision: https://phabricator.dev.yugabyte.com/D14504
  • Loading branch information
kneeraj committed Feb 9, 2022
1 parent c7dbb3d commit 3c565a1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion java/yb-pgsql/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<dependency>
<groupId>com.yugabyte</groupId>
<artifactId>jdbc-yugabytedb</artifactId>
<version>42.3.0</version>
<version>42.3.3</version>
</dependency>
<dependency>
<groupId>org.json</groupId>
Expand Down

0 comments on commit 3c565a1

Please sign in to comment.