[pre-commit.ci] pre-commit autoupdate #4895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
|
I'll push a manual fix for the new linting rule |
neutrinoceros
force-pushed
the
pre-commit-ci-update-config
branch
from
c5ba7c3
to
869c228
Compare
neutrinoceros
added
infrastructure
neutrinoceros
previously approved these changes
May 6, 2024
neutrinoceros
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
e9b846f
to
3f7bc52
Compare
updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) - [github.com/astral-sh/ruff-pre-commit: v0.4.0 → v0.4.3](astral-sh/ruff-pre-commit@v0.4.0...v0.4.3) - [github.com/MarcoGorelli/cython-lint: v0.16.0 → v0.16.2](MarcoGorelli/cython-lint@v0.16.0...v0.16.2)
neutrinoceros
force-pushed
the
pre-commit-ci-update-config
branch
from
3f7bc52
to
6902032
Compare
cphyc
approved these changes
May 8, 2024
| str(type(obj)).split("'")[1], len(obj) | ||
| ) | ||
| f"Expected an array of size (3,), " | ||
| f"received {_full_type_name(obj)!r} of length {len(obj)}" |
There was a problem hiding this comment.
Why _full_type_name(obj)!r rather than just _full_type_name(obj)? Is it just to get the '' for free?
There was a problem hiding this comment.
s it just to get the '' for free?
yes
| @@ -290,7 +290,7 @@ def transfer_function(self, value): | |||
| if not isinstance(value, valid_types): | |||
| raise RuntimeError( | |||
| "transfer_function not a valid type, " | |||
| "received object of type %s" % type(value) | |||
| f"received object of type {type(value)}" | |||
There was a problem hiding this comment.
Suggested change
| f"received object of type {type(value)}" | |
| f"received object of type {type(value)}." |
There was a problem hiding this comment.
I'm trying not to change the result at all, so I'd rather skip this
There was a problem hiding this comment.
Fair enough, I'm happy with the PR as is.
neutrinoceros
added
infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates: