BUG: Fix tipsy file handler opening #4884
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishavlin
reviewed
Apr 26, 2024
| @@ -209,7 +212,7 @@ def _read_particle_data_file(self, data_file, ptf, selector=None): | |||
|
|
|||
| # close all file handles | |||
| f.close() | |||
| for fh in list(aux_fh.values()): | |||
| for fh in list(_aux_fh.values()): | |||
There was a problem hiding this comment.
since you touched this line, might as well get rid of the unneeded cast to list
Suggested change
| for fh in list(_aux_fh.values()): | |
| for fh in _aux_fh.values(): |
|
@yt-fido test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not change anything functionally, but can save some time for opening file handles that may be expensive.
Closes #4883.