Add support for self-shielding in heating/cooling rates calculation #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphyc
force-pushed
the
RAMSES-self-shielding
branch
from
1aeb427
to
37490b0
Compare
cphyc
force-pushed
the
RAMSES-self-shielding
branch
from
37490b0
to
fee05ef
Compare
V-Nathir
reviewed
Apr 11, 2024
Hydrogen abundances are defined as (1 - Y) × (1 - Z), where Y is the hard-coded primordial Helium fraction and Z is the regular metallicity. Co-authored-by: Víctor Rufo Pastor <67118212+V-Nathir@users.noreply.github.com>
cphyc
added
code frontends
chrishavlin
reviewed
Apr 11, 2024
Co-authored-by: Chris Havlin <chris.havlin@gmail.com>
|
@yt-fido test this please |
|
Let's hold this a bit more, we probably need testing before this goes in! |
|
okay, converting to draft then ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
RAMSES uses some self-shiedling to compute the cooling/heating rates.
This parameter is used in
hydro/cooling_fine.f90. When self-shielding is activated, a "boost factor" is computed asboost =exp(-nH/0.01), and the effective density used to look-up the cooling tables is
nH/boost.PR Checklist