Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #3494 on branch yt-4.0.x (MNT: migrate away from packaging.version.parse) #3650

Conversation

meeseeksmachine
Copy link

Backport PR #3494: MNT: migrate away from packaging.version.parse

@lumberbot-app lumberbot-app bot added the enhancement Making something better label Nov 6, 2021
@neutrinoceros
Copy link
Member

neutrinoceros commented Nov 6, 2021

Note to reviewers: while not strictly a bug fix, backporting this will enable automated backports for the following, otherwise conflicting PRs:

@neutrinoceros neutrinoceros added this to the 4.0.2 milestone Nov 6, 2021
@munkm
Copy link
Member

munkm commented Nov 6, 2021

I thought individual backports were on pause until a solution to bulk them in a single PR like @Xarthisius suggested was found?

@neutrinoceros
Copy link
Member

I don't recall us agreeing on a strategy, and no one has proposed to help after 3 weeks.

We cannot bulk such a large number of PRs in a reproducible fashion because there were originally many conflict and order sensitive operations.
Bulking would be more error prone and it wouldn't be nearly as trivial to review as an identical patch.

I get it, people are busy and notifications are annoying, but we are now extremely close to completion with the existing strategy. Can we please finish this before it turns unmanageable again ?

@munkm
Copy link
Member

munkm commented Nov 7, 2021

If all bugfixes are backported in a single PR with a separate commit for each backport, how would that have an issue with order sensitivity if CI is only tested on the last commit? That's what Kacper was saying.

@neutrinoceros
Copy link
Member

I'll fully admit that I did not understand this was the proposed alternative. Well, I can to this for this one + the whole list here https://github.com/yt-project/yt/pulls?q=is%3Apr+label%3A%22Still+Needs+Manual+Backport%22+is%3Aclosed+
which would complete the list in the 4.0.2 meta issue.

@neutrinoceros
Copy link
Member

done in #3651, which now supersedes this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Making something better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants