Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict sympy to 1.8 #3550

Merged
merged 2 commits into from Oct 11, 2021
Merged

Restrict sympy to 1.8 #3550

merged 2 commits into from Oct 11, 2021

Conversation

Xarthisius
Copy link
Member

@Xarthisius Xarthisius added the bug label Oct 11, 2021
@matthewturk
Copy link
Member

@Xarthisius thank you for doing this. If it does indeed fix the issues, it should be merged. I've marked it for auto-merge, which will pass if py38 passes, and it will go in.

neutrinoceros
neutrinoceros approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me as a temporary workaround, thanks !

@neutrinoceros
Copy link
Member

@Xarthisius don't hesitate to kill jobs that are queued before this one on Jenkins

@neutrinoceros
Copy link
Member

There's one failure remaining, which I believe is only due to an unfortunate chronology with merging #3520 and #3533
the actual result is correct, @Xarthisius, can you bump ?

@matthewturk matthewturk merged commit b14a1cb into yt-project:main Oct 11, 2021
This was referenced Oct 13, 2021
Closed
Merged
Merged
@neutrinoceros
Copy link
Member

We need this to resolve issues on the 4.0.x branch

@meeseeksdev backport to yt-4.0.x

@meeseeksmachine meeseeksmachine mentioned this pull request Oct 16, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Oct 16, 2021
@matthewturk @meeseeksmachine
Backport PR yt-project#3550: Restrict sympy to 1.8
6dd86b3
neutrinoceros added a commit that referenced this pull request Oct 16, 2021
@neutrinoceros
Merge pull request #3596 from meeseeksmachine/auto-backport-of-pr-355…
1174920 
…0-on-yt-4.0.x

Backport PR #3550 on branch yt-4.0.x (Restrict sympy to 1.8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

@neutrinoceros neutrinoceros neutrinoceros approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Xarthisius @matthewturk @neutrinoceros