Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: rewrite backports from Python std lib in a fashion that can be automatically cleaned up with pyupgrade #3530

Closed
wants to merge 1 commit into from

Conversation

neutrinoceros
Copy link
Member

PR Summary

Title.
With the latest version of pyupgrade (that we already use as part of our pre-commit hooks),
"versioned code branches" attached to specific versions of Python 3 will now be cleaned up automatically, making their technical debt effectively 0, but they have to include an else statement.

see asottile/pyupgrade#530

@neutrinoceros neutrinoceros added the enhancement Making something better label Sep 27, 2021
@neutrinoceros
Copy link
Member Author

didn't expect this to break. Will fix later

@neutrinoceros neutrinoceros marked this pull request as draft September 27, 2021 09:42
@neutrinoceros
Copy link
Member Author

This won't work, the implementation we have for cached_property is not a back port of functools.cached_property and is not even compatible with it. Fixing this is not worth the required time for it atm, imo.

@neutrinoceros neutrinoceros deleted the future_python branch September 27, 2021 10:06
@matthewturk
Copy link
Member

If I am reading it correctly, I added cached property myself. Should we just change its name to avoid ambiguity with stdlib?

@neutrinoceros
Copy link
Member Author

That would be a good idea IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Making something better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants