ENH: rewrite backports from Python std lib in a fashion that can be automatically cleaned up with pyupgrade #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
didn't expect this to break. Will fix later |
…utomatically cleaned up with pyupgrade
neutrinoceros
force-pushed
the
future_python
branch
from
a0c8587
to
f5b5b19
Compare
|
This won't work, the implementation we have for |
|
If I am reading it correctly, I added cached property myself. Should we just change its name to avoid ambiguity with stdlib? |
|
That would be a good idea IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Title.
With the latest version of pyupgrade (that we already use as part of our pre-commit hooks),
"versioned code branches" attached to specific versions of Python 3 will now be cleaned up automatically, making their technical debt effectively 0, but they have to include an
elsestatement.see asottile/pyupgrade#530