Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump phase plots in support to PR #3520 #23

Merged
merged 1 commit into from Oct 6, 2021
Merged

bump phase plots in support to PR #3520 #23

merged 1 commit into from Oct 6, 2021

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Sep 18, 2021 •
edited

@neutrinoceros neutrinoceros mentioned this pull request Sep 18, 2021
Merged
2 tasks
@matthewturk
Copy link
Member

Probably good, right?

@neutrinoceros
Copy link
Member Author

You can convince yourself by collecting the artifacts here https://github.com/yt-project/yt/pull/3520/checks
and then use some hash comparison to make sure what I uploaded is identical.

@neutrinoceros neutrinoceros mentioned this pull request Oct 4, 2021
Merged
cphyc
cphyc approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They look good to me!

@matthewturk matthewturk merged commit d16fa21 into yt-project:yt-4.0 Oct 6, 2021
@neutrinoceros neutrinoceros deleted the support_3520 branch October 6, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cphyc cphyc cphyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neutrinoceros @matthewturk @cphyc