Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to miow to use windows-sys 0.33 #54

Closed
wants to merge 1 commit into from
Closed

Update to miow to use windows-sys 0.33 #54

wants to merge 1 commit into from

Conversation

kennykerr
Copy link
Collaborator

This brings miow in line with the parking_lot and winit crates that have already adopted windows-sys version 0.33.

@kennykerr kennykerr mentioned this pull request Mar 18, 2022
Merged
@yoshuawuyts
Copy link
Owner

Note that this PR would be a breaking change, as we're re-exporting types from windows-rs in our public API. This would mean mio would need to upgrade their version of miow each time we update windows-rs. That's not a great situation to be in.

Ideally we could evade that by defining our own wrapper with an #[repr(transparent)] that can be converted to either one of windows-rs or winapi types. But I'd like to have that in place before we update windows-rs (having it as this PR would be fine too) so that we can limit the number of breaking changes we have to issue.

@kennykerr
Copy link
Collaborator Author

Sounds good. mio hasn't yet updated to a version of miow that uses the windows-sys crate. Feel free to take over this PR and make whatever changes you need. I'm not too familiar with what's part of this crate's public API surface.

@yoshuawuyts
Copy link
Owner

(talked privately; we're going to include the required changes as part of this PR)

@faern
Copy link
Collaborator

faern commented Mar 19, 2022

parking_lot just merged an upgrade to windows-sys 0.34. Amanieu/parking_lot#331. So if the intention is to try to use the same version this PR also needs to update to that.

@kennykerr
Copy link
Collaborator Author

Feel free to reopen the PR if you'd like to push this forward.

@kennykerr kennykerr closed this Mar 29, 2022
sunfishcode added a commit to sunfishcode/miow that referenced this pull request Jul 2, 2022
@sunfishcode
Update to windows-sys 0.36.
71ec0e3 
This is now the version of windows-sys in parking_lot, mio, and most
other reverse dependencies of windows-sys.

In yoshuawuyts#54 there was a concern about this being a breaking change, but
0.36 seems an advantageous time to do that, since it's a particularly
widely-adopted version at this point.
@sunfishcode sunfishcode mentioned this pull request Jul 2, 2022
Merged
@faern faern deleted the windows-sys.33 branch August 5, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts Awaiting requested review from yoshuawuyts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kennykerr @yoshuawuyts @faern