Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm Chart Releaser Action #516

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Update Helm Chart Releaser Action #516

merged 1 commit into from
Apr 19, 2023

Conversation

krapie
Copy link
Member

@krapie krapie commented Apr 19, 2023

What this PR does / why we need it:

Update Helm Chart Releaser Action.

Three changes:

  • mark-release-latest option is also deprecated in chart-releaser-action. Therefore moved to .cr.yaml since option is still available in helm-releaser.
  • Reverted action trigger to main branch push. This is because chart-releaser-action detects chart diff by tag, therefore it will not work for publish trigger(publish involves tagging, so helm-releaser-action will see diff from published tag)
  • Updated chart dependencies

Follow helm/chart-releaser-action#137 for more information about chart-releaser-action.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@krapie krapie requested a review from hackerwins April 19, 2023 06:49
@krapie krapie self-assigned this Apr 19, 2023
@krapie
Copy link
Member Author

krapie commented Apr 19, 2023

Is there any way to test GitHub action? I cannot test action related PR, so I'm not sure about the changes that I made :(

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 5b3d2f8 into main Apr 19, 2023
1 check passed
@hackerwins hackerwins deleted the chart-release-update branch April 19, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants