Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the String() method for Frame to avoid unnecessary Encode() calls #399

Merged
merged 1 commit into from Nov 23, 2022
Merged

Implement the String() method for Frame to avoid unnecessary Encode() calls #399

merged 1 commit into from Nov 23, 2022

Conversation

wujunzhuo
Copy link
Collaborator

No description provided.

fanweixiao
fanweixiao approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@fanweixiao fanweixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

@fanweixiao fanweixiao changed the title style: formatted debug log Implement the String() method for Frame to avoid unnecessary Encode() calls Nov 23, 2022
@fanweixiao fanweixiao merged commit 0f00326 into yomorun:master Nov 23, 2022
@wujunzhuo wujunzhuo deleted the log branch November 24, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanweixiao fanweixiao fanweixiao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wujunzhuo @fanweixiao