New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add unittest #396
test: add unittest #396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 馃憤
|
||
// Object is the object to be authenticated, | ||
// The Object usually be pass to `Authenticate` function to be authed. | ||
type Object interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name Object
is too generic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Object
belongs to auth
package, It usually be called as auth.Object
.
I also think this variable name is not the best, Can you give me a suggestion ?
No description provided.