Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: broadcast frame to cascading zippers #366

Merged
merged 6 commits into from Aug 22, 2022
Merged

feat: broadcast frame to cascading zippers #366

merged 6 commits into from Aug 22, 2022

Conversation

venjiang
Copy link
Contributor

@venjiang venjiang commented Aug 16, 2022

broadcast frame to cascading zippers


This change is Reviewable

@venjiang venjiang self-assigned this Aug 16, 2022
@venjiang venjiang marked this pull request as draft August 16, 2022 15:04
@venjiang venjiang marked this pull request as ready for review August 17, 2022 08:52
core/frame/data_frame.go Outdated Show resolved Hide resolved
@fanweixiao
Copy link
Member

core/frame/meta_frame.go line 17 at r1 (raw file):

	metadata []byte
	sourceID string
	dispatch Dispatch

Is boolean better than Dispatch?

@fanweixiao
Copy link
Member

core/frame/data_frame_test.go line 22 at r1 (raw file):

	result = append(result, tidbuf...)
	result = append(result, byte(TagOfSourceID), 0x0)
	result = append(result, byte(TagOfDispatch), 0x1, 0x1)

TagOfDispatch only present when value is true.

Code quote (from source.go):

f.SetDispatch(frame.DispatchBroadcast)

@fanweixiao
Copy link
Member

core/frame/data_frame.go line 79 at r1 (raw file):

// Dispatch get dispatch mode
func (d *DataFrame) Dispatch() Dispatch {

should be IsDispatch() better?

@fanweixiao
Copy link
Member

Shall we uniform the word, dispatch or broadcast?

Copy link
Member

@fanweixiao fanweixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @venjiang and @wujunzhuo)

@venjiang
Copy link
Contributor Author

venjiang commented Aug 18, 2022

Shall we uniform the word, dispatch or broadcast?

Yeah, It should be named broadcast if there is only one dispatch mode.
Can we have other dispatch modes?

@venjiang venjiang merged commit 3acb5e4 into master Aug 22, 2022
@venjiang venjiang deleted the feat/broadcast branch August 22, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants