Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Context pool #356

Merged
merged 2 commits into from Jul 29, 2022
Merged

feat: add Context pool #356

merged 2 commits into from Jul 29, 2022

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Jul 28, 2022 •
edited by fanweixiao

Use sync.pool to hold the Context.

This change is Reviewable

@woorui
Copy link
Collaborator Author

woorui commented Jul 28, 2022

yomo/core/context.go

Line 24 in be83e59

Keys map[string]interface{}

And I find this field was named Keys, Is it more appropriate to rename to Values ?

@venjiang venjiang self-requested a review July 29, 2022 11:23
@venjiang venjiang merged commit 8609dff into yomorun:master Jul 29, 2022
@woorui woorui deleted the feat/ctx-pool branch July 29, 2022 15:47
@fanweixiao fanweixiao changed the title Feat/ctx pool feat: add Context pool Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venjiang venjiang venjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@woorui @venjiang