Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(listener): remove redundant dependence #353

Merged
merged 2 commits into from Jul 26, 2022
Merged

refactor(listener): remove redundant dependence #353

merged 2 commits into from Jul 26, 2022

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Jul 18, 2022 •
edited by fanweixiao

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@venjiang
Copy link
Contributor

😀 Yeah, there was a different implementation of the listener earlier, and we need to consider changing the interface.

@woorui
Copy link
Collaborator Author

woorui commented Jul 18, 2022 •
edited

Yes, I saw that newListener function do nothing.

@fanweixiao fanweixiao merged commit 365e71c into yomorun:master Jul 26, 2022
@fanweixiao
Copy link
Member

Thanks @woorui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wujunzhuo wujunzhuo wujunzhuo approved these changes

@venjiang venjiang Awaiting requested review from venjiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@woorui @CLAassistant @venjiang @fanweixiao @wujunzhuo