Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return nil when encounter a non-nil error #345

Merged
merged 1 commit into from Jun 23, 2022
Merged

Fix return nil when encounter a non-nil error #345

merged 1 commit into from Jun 23, 2022

Conversation

xieyuschen
Copy link
Contributor

@xieyuschen xieyuschen commented Jun 23, 2022 •
edited by fanweixiao

I believe it might be a careless bug as it returns nil even if there is a non-error.

This change is Reviewable

fanweixiao
fanweixiao approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@fanweixiao fanweixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fanweixiao fanweixiao added the bug Something isn't working label Jun 23, 2022
@fanweixiao fanweixiao merged commit c7bfc2a into yomorun:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanweixiao fanweixiao fanweixiao approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xieyuschen @fanweixiao