Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor Connector to make code more expressive #329

Merged
merged 14 commits into from May 26, 2022
Merged

refactor: refactor Connector to make code more expressive #329

merged 14 commits into from May 26, 2022

Conversation

wujunzhuo
Copy link
Collaborator

@wujunzhuo wujunzhuo commented May 12, 2022 •
edited by fanweixiao

This change is Reviewable

@wujunzhuo wujunzhuo marked this pull request as draft May 12, 2022 09:14
@wujunzhuo wujunzhuo marked this pull request as ready for review May 13, 2022 02:38
@fanweixiao fanweixiao changed the title refactor: support customized extensions for allegro and advanced developers refactor: support customized extensions for advanced developers May 13, 2022
@wujunzhuo wujunzhuo marked this pull request as draft May 13, 2022 03:36
@wujunzhuo wujunzhuo marked this pull request as ready for review May 19, 2022 08:23
fanweixiao
fanweixiao reviewed May 19, 2022
View reviewed changes
router.go Outdated Show resolved Hide resolved
router.go Outdated Show resolved Hide resolved
venjiang
venjiang reviewed May 20, 2022
View reviewed changes
app_info.go Outdated Show resolved Hide resolved
@fanweixiao fanweixiao changed the title refactor: support customized extensions for advanced developers refactor: refactor Connector to make code more expressive May 21, 2022
venjiang
venjiang reviewed May 23, 2022
View reviewed changes
meta_data.go Outdated Show resolved Hide resolved
core/frame/frame.go Outdated Show resolved Hide resolved
core/frame/meta_frame.go Outdated Show resolved Hide resolved
core/frame/meta_frame.go Outdated Show resolved Hide resolved
@venjiang venjiang merged commit 54217c9 into yomorun:master May 26, 2022
@wujunzhuo wujunzhuo deleted the ref/app branch May 26, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanweixiao fanweixiao fanweixiao approved these changes

@venjiang venjiang venjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wujunzhuo @fanweixiao @venjiang