Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin.py::get_python_version - new pypy support #50

Merged
merged 2 commits into from
Dec 30, 2020

Conversation

DorianGray
Copy link
Contributor

actions/setup-python#136

Changes slightly how pypy version strings are handled to match more
recent github actions changes.

actions/setup-python#136

Changes slightly how pypy version strings are handled to match more
recent github actions changes.
@DorianGray DorianGray mentioned this pull request Dec 20, 2020
@ymyzk
Copy link
Owner

ymyzk commented Dec 30, 2020

@DorianGray, thank you for your contribution! The change looks good to me.

One caveat is that this can be a breaking change for existing users because users are expected to update existing configurations like pypy3 to pypy-3.6. I'll push another PR to save existing users soon.

@ymyzk ymyzk merged commit 9fd8296 into ymyzk:master Dec 30, 2020
ymyzk added a commit that referenced this pull request Dec 30, 2020
This is for recovering backward compatibility after merging a breaking
change to support PyPy minor versions in #50. Also, this change can
provide more flexibility for simpler use cases.
@DorianGray DorianGray deleted the pypy-3.7-support branch December 30, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants