Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: output request count #3

Merged
merged 9 commits into from Mar 19, 2020

Conversation

ylecuyer
Copy link
Owner

Improve the output

Demo:
https://youtu.be/iILkbEsDSxc

@ylecuyer
Copy link
Owner Author

@jarthod wdyt ?

@jarthod
Copy link

jarthod commented Jan 26, 2020

Looks nice! Thanks for the video. Two minor things:

  • is the request number in red when it's big? For people who don't use worker killer it may look weird (always red)
  • "Rqs" sounds a bit like requests/seconds to me, I would probably choose something like "Req" instead.
    Good job :)

@ylecuyer
Copy link
Owner Author

  • is the request number in red when it's big? For people who don't use worker killer it may look weird (always red)

Right, I'll remove the color

  • "Rqs" sounds a bit like requests/seconds to me, I would probably choose something like "Req" instead.

I discussed this with @misdoro and I had the same feeling, I'll change it to Req

@jarthod
Copy link

jarthod commented Jan 26, 2020

👌

# Conflicts:
#	lib/core.rb
#	lib/stats.rb
@ylecuyer ylecuyer changed the title Improvement: better output + request count Improvement: output request count Jan 28, 2020
lib/stats.rb Outdated Show resolved Hide resolved
lib/stats.rb Outdated Show resolved Hide resolved
@ylecuyer ylecuyer merged commit 9818484 into master Mar 19, 2020
@ylecuyer ylecuyer deleted the better-output-requests-count-yle branch March 19, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants