Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#386 Move create button outside of pjax container #401

Merged
merged 2 commits into from
Feb 19, 2019
Merged

#386 Move create button outside of pjax container #401

merged 2 commits into from
Feb 19, 2019

Conversation

alexkart
Copy link
Contributor

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #386

@machour
Copy link
Member

machour commented Feb 18, 2019 •
edited

Can you comment with a before/after screenshot ?

@machour machour added the type:bug Bug label Feb 18, 2019
@alexkart
Copy link
Contributor Author

They are exactly the same.
Before:
c403f8eb71f13afbe4c9531c2ca7fa43

After:
cee0729968ce26464add07f81876d0f5

samdark
samdark approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line for changelog. Thanks.

@samdark samdark merged commit 7139eb8 into yiisoft:master Feb 19, 2019
@samdark
Copy link
Member

samdark commented Feb 19, 2019

Thank you!

@samdark samdark added this to the 2.1.0 milestone Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@machour machour machour approved these changes

Assignees
No one assigned
Labels
type:bug Bug
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexkart @machour @samdark