Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect generator of title for crud update view #383

Merged
merged 5 commits into from
Nov 12, 2018
Merged

fix incorrect generator of title for crud update view #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
522324b
fix incorrect generator of title for crud update view
bscheshirwork Oct 24, 2018
a548136
:book:
bscheshirwork Nov 12, 2018
7084ec0
Update CHANGELOG.md
samdark Nov 12, 2018
90b4f00
Merge branch 'master' into fix-incorrect-generator-of-title
samdark Nov 12, 2018
cf49213
Update CHANGELOG.md
samdark Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Yii Framework 2 gii extension Change Log
- Bug #327: Fixed bug in Model generator when $baseClass is an abstract class (rhertogh)
- Enh #366: Option to allow standardized class names capitals in model generator (slinstj)
- Enh #378: Remove useless import of `Yii` from CRUD generator search model template (CeBe)
- Bug #383: Fix incorrect title generation in CRUD update view (bscheshirwork)


2.0.7 May 3, 2018
Expand Down
10 changes: 5 additions & 5 deletions src/generators/crud/default/views/update.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
/* @var $generator yii\gii\generators\crud\Generator */

$urlParams = $generator->generateUrlParams();
$modelClassName = Inflector::camel2words(StringHelper::basename($generator->modelClass));
$nameAttributeTemplate = '$model->' . $generator->getNameAttribute();
$titleTemplate = $generator->generateString('Update ' . $modelClassName . ': {name}', ['name' => '{nameAttribute}']);
$title = strtr($titleTemplate, ['\'{nameAttribute}\'' => $nameAttributeTemplate]);

echo "<?php\n";
?>
Expand All @@ -16,11 +20,7 @@
/* @var $this yii\web\View */
/* @var $model <?= ltrim($generator->modelClass, '\\') ?> */

$this->title = <?= strtr($generator->generateString('Update ' .
Inflector::camel2words(StringHelper::basename($generator->modelClass)) .
': {nameAttribute}', ['nameAttribute' => '{nameAttribute}']), [
'{nameAttribute}\'' => '\' . $model->' . $generator->getNameAttribute()
]) ?>;
$this->title = <?= $title ?>;
$this->params['breadcrumbs'][] = ['label' => <?= $generator->generateString(Inflector::pluralize(Inflector::camel2words(StringHelper::basename($generator->modelClass)))) ?>, 'url' => ['index']];
$this->params['breadcrumbs'][] = ['label' => $model-><?= $generator->getNameAttribute() ?>, 'url' => ['view', <?= $urlParams ?>]];
$this->params['breadcrumbs'][] = <?= $generator->generateString('Update') ?>;
Expand Down