Fixed Model Generator to support abstract baseClass #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes yiisoft#327 Checks if baseClass is an abstract class, and if so wrap it in a regular class before instantiating it.
samdark
approved these changes
May 23, 2018
|
@samdark fixed |
Removed obsolete class_exists check since ReflectionClass already checks if class exists.
|
I've removed the redundant class_exists check from the original pull request since ReflectionClass already checks if class exists. |
samdark
added
type:bug
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if baseClass is an abstract class, and if so wrap it in a regular class before instantiating it.