Ambiguous usage of pjax

[bscheshirwork]

What steps will reproduce the problem?

Use crud generator

What's expected?

pjax template exclude "create" button

    <p>
        <?= "<?= " ?>Html::a(<?= $generator->generateString('Create ' . Inflector::camel2words(StringHelper::basename($generator->modelClass))) ?>, ['create'], ['class' => 'btn btn-success']) ?>
    </p>

<?= $generator->enablePjax ? "    <?php Pjax::begin(); ?>\n" : '' ?>
<?php if(!empty($generator->searchModelClass)): ?>
<?= "    <?php " . ($generator->indexWidgetType === 'grid' ? "// " : "") ?>echo $this->render('_search', ['model' => $searchModel]); ?>
<?php endif; ?>

What do you get instead?

pjax template included "create" button

<?= $generator->enablePjax ? "    <?php Pjax::begin(); ?>\n" : '' ?>
<?php if(!empty($generator->searchModelClass)): ?>
<?= "    <?php " . ($generator->indexWidgetType === 'grid' ? "// " : "") ?>echo $this->render('_search', ['model' => $searchModel]); ?>
<?php endif; ?>


    <p>
        <?= "<?= " ?>Html::a(<?= $generator->generateString('Create ' . Inflector::camel2words(StringHelper::basename($generator->modelClass))) ?>, ['create'], ['class' => 'btn btn-success']) ?>
    </p>

yii2-gii/src/generators/crud/default/views/index.php

Lines 34 to 36 in 6d30fa9

	<p>
	<?= "<?= " ?>Html::a(<?= $generator->generateString('Create ' . Inflector::camel2words(StringHelper::basename($generator->modelClass))) ?>, ['create'], ['class' => 'btn btn-success']) ?>
	</p>

Additional info

Q	A
Yii version	dev
PHP version	7.2.11
Database version
Operating system

[samdark]

Why should it exclude "create" button?

[bscheshirwork]

This action is not a pjax action and can be place outside pjax container for avoid unnecessery redirect after pjax fail

[samdark]

OK. Could you send a pull request fixing it?

[SOHELAHMED7]

Either we can go with @bscheshirwork or we can add a attribute data-pjax="0" link

[samdark]

Yes. Correct.

[SOHELAHMED7]

Should I go ahead with PR?

[bscheshirwork]

@SOHELAHMED7 @samdark

data-pjax="0"

is not a correct way for new project,
but this variant is safe for existing projects;
we can use css for nested rules.

[samdark]

@bscheshirwork agree.