Fixes #383: Fix incorrect title generation in CRUD update view

yiisoft · Nov 12, 2018 · 26faa5c · 26faa5c
1 parent 6d30fa9
commit 26faa5c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@ Yii Framework 2 gii extension Change Log
 - Bug #327: Fixed bug in Model generator when $baseClass is an abstract class (rhertogh)
 - Enh #366: Option to allow standardized class names capitals in model generator (slinstj)
 - Enh #378: Remove useless import of `Yii` from CRUD generator search model template (CeBe)
+- Bug #383: Fix incorrect title generation in CRUD update view (bscheshirwork)
 
 
 2.0.7 May 3, 2018

diff --git a/src/generators/crud/default/views/update.php b/src/generators/crud/default/views/update.php
@@ -7,6 +7,10 @@
 /* @var $generator yii\gii\generators\crud\Generator */
 
 $urlParams = $generator->generateUrlParams();
+$modelClassName = Inflector::camel2words(StringHelper::basename($generator->modelClass));
+$nameAttributeTemplate = '$model->' . $generator->getNameAttribute();
+$titleTemplate = $generator->generateString('Update ' . $modelClassName . ': {name}', ['name' => '{nameAttribute}']);
+$title = strtr($titleTemplate, ['\'{nameAttribute}\'' => $nameAttributeTemplate]);
 
 echo "<?php\n";
 ?>
@@ -16,11 +20,7 @@
 /* @var $this yii\web\View */
 /* @var $model <?= ltrim($generator->modelClass, '\\') ?> */
 
-$this->title = <?= strtr($generator->generateString('Update ' .
-    Inflector::camel2words(StringHelper::basename($generator->modelClass)) .
-    ': {nameAttribute}', ['nameAttribute' => '{nameAttribute}']), [
-    '{nameAttribute}\'' => '\' . $model->' . $generator->getNameAttribute()
-]) ?>;
+$this->title = <?= $title ?>;
 $this->params['breadcrumbs'][] = ['label' => <?= $generator->generateString(Inflector::pluralize(Inflector::camel2words(StringHelper::basename($generator->modelClass)))) ?>, 'url' => ['index']];
 $this->params['breadcrumbs'][] = ['label' => $model-><?= $generator->getNameAttribute() ?>, 'url' => ['view', <?= $urlParams ?>]];
 $this->params['breadcrumbs'][] = <?= $generator->generateString('Update') ?>;