Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pretty print for arrays #231

Merged
merged 63 commits into from
Dec 1, 2021
Merged

Added pretty print for arrays #231

merged 63 commits into from
Dec 1, 2021

Conversation

arogachev
Copy link
Contributor

@arogachev arogachev commented Nov 29, 2021 •
edited

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues #18

Important notes:

  • Comments and whitespaces are removed.
  • Nesting arrays are supported too.
  • Trailing comma is added after the last element.

Before:

Screenshot 2021-11-29 at 17-09-31 Schema, yii db pgsql Schema

After:

Screenshot 2021-11-29 at 17-11-50 Schema, yii db pgsql Schema

Bizley and others added 30 commits August 30, 2021 15:20
Draft for 3.0
7aa586d
@arogachev
Merge remote-tracking branch 'origin/3.0' into 3.0
0f5df6c
@arogachev
Simplify dependencies in composer.json
b8e27f6
@arogachev
Minimal working version, various fixes
ac33ed2
@arogachev
Remove older PHP versions for tests, add PHP 8
072e760
@arogachev
Allow PHP 8 as a dependency in composer.json
1ac13d8
@arogachev
Leave hard coded value (isReturnByReference in FunctionDoc)
79f933e
@arogachev
Remove unnecessary elseif block
b1095fc
@arogachev
Move construct method to the top, remove commented out code
c70b044
@arogachev
Make use of StringHelper::mb_ucfirst()
22ab8c5
@arogachev
Actualize stubs for setting type and types based on getType()
2f798bf
@arogachev
Use fork, restore endLine and isReturnByReference logic
186944f
@arogachev
Handle getNode()->default, do not remove deprecated methods' bodies
aaf5dbd
@arogachev
Removed author for consistency
d12e8ce
@arogachev
Cleanup
6036566
@arogachev
Handle type / types in TypeDoc, get rid of addProjectFile
7f1178a
@arogachev
Fix undefined variable $type
b3b44fc
@arogachev
Cleanup tests
e4f989c
@arogachev
Fix first 5 errors after testing on Yii 2 docs
ab6b134
@arogachev
Make setUp compatible with parent (PHPUnit)
01f5450
@arogachev
Fix "Undefined array key 0" error
63f5426
@arogachev
Fix "Call to undefined method Generic::getContent()" in Context
1207b7a
@arogachev
Fix "Class Collection not found" error
fcafd6a
@arogachev
Fix regression with parentheses with MethodDoc
f246153
@arogachev
Fix property-read / property-write parsing issues
73f12e8
@arogachev
Fix event description (was merged with class name and not capitalized)
3b700bd
@arogachev
Fix issue when "seeAlso" partial template was not rendered
7b3e0d3
@arogachev
Revert str_contains -> strpos
b381335
@arogachev
Handle null in aggregated type during split types
598c559
@arogachev
Fix broken links
1b432ff
@arogachev
Simplify string concatenation even more
c3eadfe
@arogachev
Issue #133 is fixed too [skip ci]
8dd3238
@arogachev
Issue #155 is fixed too [skip ci]
bb1d465
@arogachev
Issue #162 is fixed too [skip ci]
87b8d63
@arogachev
Issue #179 is fixed too [skip ci]
21f8055
@arogachev
Issue #199 is fixed too [skip ci]
bcc44fa
@arogachev
Fix issue #143 (do not include internal methods and properties) [skip…
7e98c64 
… ci]
@arogachev
Add issue #180 in CHANGELOG.md[skip ci]
255733f
@arogachev
Add issue #148 to CHANGELOG.md [skip ci]
f9bef8f
@arogachev
Fixed issue #197 [skip ci]
5b2f0b7
@arogachev
Add prefix and suffix when fixing Markdown links
7ceaa5a
@arogachev
Merge branch 'master' into 3.0
969362b 
# Conflicts:
#	CHANGELOG.md
@arogachev
Do not add guide prefix to non-Markdown links
bb94d19
@arogachev
Extract changes for issue #180 to a separate branch
5b068ef
@arogachev
Extract changes for issue #197 to a separate branch
d97b25c
@arogachev
Remove whitespace at the end of line [skip ci]
0ec0800
@arogachev
Group overridden methods together [skip ci]
632f520
@arogachev
Add "@link" tag [skip ci]
318f465
@arogachev
Added pretty print for arrays
fef4c88
@arogachev arogachev added the type:enhancement Enhancement label Nov 29, 2021
@arogachev arogachev requested a review from a team November 29, 2021 11:08
@arogachev arogachev self-assigned this Nov 29, 2021
@arogachev
Copy link
Contributor Author

Here are 2 main reasons for removing of comments:

But this can be a subject to discuss.

@samdark samdark added the status:code review The pull request needs review. label Dec 1, 2021
@samdark samdark merged commit 4d569ec into yiisoft:master Dec 1, 2021
@arogachev arogachev deleted the 18-array-pretty-print branch December 2, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees

@arogachev arogachev

Labels
status:code review The pull request needs review. type:enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arogachev @samdark