Add Tailwind to Test Site and e2e-tests #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextaing
changed the title
alextaing
force-pushed
the
dev/tailwind-in-tests
branch
from
02758f5
to
d8a1bef
Compare
alextaing
force-pushed
the
dev/tailwind-in-tests
branch
from
223f829
to
9c9435b
Compare
nmanu1
reviewed
Oct 26, 2023
tmeyer2115
approved these changes
Oct 26, 2023
tmeyer2115
approved these changes
Oct 26, 2023
nmanu1
reviewed
Oct 26, 2023
nmanu1
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures Tailwind in our test site and end-to-end tests. We also re-introduce screenshots for Darwin that we turned off in (#412). Note that the
loadingOverlaywait was fixed in ourStudioPlaywrightPage. Before, we waited for a button to be visible as a check for the overlay to be gone. However, Playwright only considershiddenelements to be not visible, while ourloadingOverlayusesopacityto "toggle" visibility. Additionally, since Playwright defaults to fast-forwarding transitions fortoHaveScreenshot, we shouldn't have to worry about the opacity transition time.I also squeeze in a quick variable rename from
userStylestoactiveStyleto more accurately describe that we are not injecting all user styles, but only the ones on the active page and its component tree.J=SLAP-2912
TEST=auto, manual