Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tailwind to 3.3.3 #313

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Bump tailwind to 3.3.3 #313

merged 6 commits into from
Aug 7, 2023

Conversation

alextaing
Copy link
Contributor

@alextaing alextaing commented Aug 3, 2023

Bump to tailwind 3.3.3 so that we can use .ts config files. Does not include breaking changes.

Some things of note:
This change seems to have caused some problems for users using Safari <14.1 and some mobile browsers.
More on tailwind changes can be found here, and the commit changes can be found here.

Prettier was also bumped to 2.8.1 (only the test site was on an old version, 2.7.1). This is because the auto-generated tailwind.config.ts file makes use of the new satisfies keyword which is not supported until Prettier 2.8.1. This broke our linking workflow.

J=SLAP-2820

@alextaing alextaing added the wip label Aug 3, 2023
@alextaing alextaing closed this Aug 3, 2023
@alextaing alextaing reopened this Aug 4, 2023
@alextaing alextaing removed the wip label Aug 4, 2023
Copy link
Collaborator

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update our tailwind config files to be .ts now that tailwind supports that?

@alextaing alextaing closed this Aug 4, 2023
@alextaing alextaing reopened this Aug 4, 2023
@alextaing alextaing merged commit a517fa0 into main Aug 7, 2023
12 checks passed
@alextaing alextaing deleted the dev/bump-tailwind-3.3 branch August 7, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants